Skip to content
This repository has been archived by the owner on Oct 18, 2018. It is now read-only.

Add tooltips to elements in the add-on bar widgets #60

Closed
whimboo opened this issue Feb 10, 2012 · 8 comments
Closed

Add tooltips to elements in the add-on bar widgets #60

whimboo opened this issue Feb 10, 2012 · 8 comments
Labels
Milestone

Comments

@whimboo
Copy link
Contributor

whimboo commented Feb 10, 2012

To explain the different shown values to the user we should display tooltips. See my blog post for the content we could use:
http://www.hskupin.info/2012/02/10/memchaser-an-extension-to-track-firefoxs-memory-activities/

@dglol
Copy link
Contributor

dglol commented Feb 11, 2012

My state machine/flip-flop using :onmouseover and :onmouseout is a simple way to solve this. The robustness of it with multiple elements is to be seen.

Code of interest:
https://github.com/dglol/memchaser/blob/uniwidget/extension/data/widget/widget.js#L57
https://github.com/dglol/memchaser/blob/uniwidget/extension/lib/main.js#L87

@whimboo
Copy link
Contributor Author

whimboo commented Feb 11, 2012

With this method we would only be able to give an explanation of the widget itself or the logger but not for each individual entry inside the widget. Could we use HTML tooltips inside the widget to display the additional information?

@dglol
Copy link
Contributor

dglol commented Feb 12, 2012

What I meant was that the tooltip fix for the logger can be applied to the individual entries since they have unique ID identifiers that we can bind the onmouseover and onmouseout events to. Based on experimentation, I don't believe setting 'title' in the entries will override the default tooltip.

@whimboo
Copy link
Contributor Author

whimboo commented Feb 13, 2012

I don't think that we should pass events from chrome to content for any of those tooltips. I would certainly prefer a content only implementation.

@anon-user
Copy link

From the referenced website, the phrase "in brackets the time when the second last activity happened" is not particularly clear, as:
(a) negative values have been observed;
(b) time can reference duration of the event;
(c) time can reference elapsed time since the event;
(d) activity is ambiguous.

As I (perhaps mistakenly) understand thus far, this is really:

[end-time of either two CCs ago if not currently CCing, or of last CC if currently CCing]
less
[start-time of either last CC if not currently CCing, or of current CC if currently CCing]

Thus:
Negative values indicate concurrent CC events -- the next started before the last completed.
Positive values indicate sequential CC events -- the last completed before the next started.

If my understanding is incorrect, then we really need better documentation here.
Granted, tooltips should generally be succinct, but here we should be reasonably precise.

Perhaps:
Time between the end of the prior CC until the start of the current (or last) CC.

@dglol
Copy link
Contributor

dglol commented Mar 11, 2012

Time between the end of the prior CC until the start of the current (or last) CC.

This should be the correct interpretation. The negative values should not have been observed; this is most likely a bug that I can't seem to reproduce (I tried spamming the force GC/CC buttons in about:memory). How often do you see this bug?

@whimboo
Copy link
Contributor Author

whimboo commented Mar 12, 2012

I also have seen negative numbers. It's really really rare. So no way yet to get it reproduced. You can file a new issue if you want to have it investigated and addressed.

@whimboo
Copy link
Contributor Author

whimboo commented Mar 20, 2012

Fixed with pull #84.

@whimboo whimboo closed this as completed Mar 20, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants