Skip to content
This repository has been archived by the owner on Sep 12, 2018. It is now read-only.

[tx] Don't parse EDN to construct bootstrap schema during bootstrap phase #193

Open
ncalexan opened this issue Jan 23, 2017 · 1 comment
Labels
A-edn EDN parser issues. A-transact Issues or requests in the transactor.

Comments

@ncalexan
Copy link
Member

In #170, I got frustrated defining static structures in Rust and lazily parsed some EDN to represent symbolic schemas. We then turn around and transform the parsed structures into simpler triples to iterate over. This is all around the bootstrap V2_SYMBOLIC_SCHEMA code.

This ticket tracks defining a nested [(IDENT, [(ATTRIBUTE, VALUE), ...]), ...] structure in Rust directly, and avoiding using the EDN parser (and potentially even Value for the ident, attribute, and tree structure parts) during bootstrap.

This is a reasonable [good first bug].

@rnewman
Copy link
Collaborator

rnewman commented Jan 23, 2017

Somewhere I thought I filed an issue about parsing queries at compile time.

It's hard without const fn and perhaps some other support, but eventually there's no reason why a static EDN tree can't be parsed at compile time, all the way through to an abstract transact input or an abstract query.

Obviously we can also define a bunch of macros (or do it manually) to define the intermediate structures programmatically, which I guess is this ticket :)

@ncalexan ncalexan added rust and removed rust labels Jan 26, 2017
@rnewman rnewman added A-edn EDN parser issues. A-transact Issues or requests in the transactor. and removed rust labels Mar 22, 2018
@rnewman rnewman added this to the Production-ready milestone Mar 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-edn EDN parser issues. A-transact Issues or requests in the transactor.
Projects
None yet
Development

No branches or pull requests

2 participants