This repository has been archived by the owner on Sep 12, 2018. It is now read-only.
[tx] Accept [a v] notation for lookup refs in entity position #392
Labels
A-transact
Issues or requests in the transactor.
enhancement
good first bug
help wanted
hygiene
ready
Milestone
This is follow-up tracking #382 (review). In #382, I accept only
(lookup-ref a v)
for lookup-refs in both entity and value position (e
andv
in a[:db/add e _ v]
assertion). That's contrary to Datomic, which accepts embedded vectors like[a v]
in both locations, treating ambiguity in some ad-hoc way. (See the discussion in #183 for notes on this ambiguity.)This ticket tracks accepting an embedded vector
[a v]
in the entity position only. We suspect that the majority of lookup refs are entity refs in this form, and it's both shorter to type and handy to agree with Datomic.To implement this, you'll need to:
entid_or_lookup_ref_or_temp_id
is still used only to parse entity positions;vector_lookup_ref
function accepting[a v]
aroundmentat/tx-parser/src/lib.rs
Line 72 in 8adb6d9
mentat/tx-parser/src/lib.rs
Line 88 in 8adb6d9
The text was updated successfully, but these errors were encountered: