bug: Lines with only one value are invisible in line char (thougn dots are shown on activating)

[blazkovicz]

I suggest to show dots for such lines permanently.
Additional problem: if there is only one line with a single point - that point is really hard to show: cursor must be on exact same x-coordinate as point to view it.

[almossawi]

Hi @blazkovicz To your second point, the rollover rectangle ought to cover the entire area when there's a single data point, as in the screenshot below.

[blazkovicz]

@almossawi, i copied code to plnkr: http://plnkr.co/edit/03MPKoNNgr6NfjQEuLgs
in script.js there is copy of d3 v3.5.3 and metrics-graphics v2.0.0 (from bower).
also about main topic: not every user will have insight to move mouse over an empty graphic to see that it has some data actually.

[blazkovicz]

Ah, after so much effort to reproduce bug in plnkr, I go to the metrics-graphics interactive and see, that it was pretty simple task:

On this graphic it's almost inpossible to find that single dot. =)
It's a fresh bug, I see.

[almossawi]

Oh, the fix is in master (see #289), and hence not yet deployed :) It will be in the upcoming v2.1.

To your first point, I think you're right. Hamilton and I chatted about that too, and decided that it wouldn't be an issue to break the pattern for line charts for datasets of length 1. I'll take a look at that on Monday.

[blazkovicz]

Thank you!

[almossawi]

@blazkovicz Done.

[blazkovicz]

Thanks! Is update available already?

[almossawi]

The change is committed. We're planning to release v2.1 on Thursday,
January 22.

On Tue, Jan 20, 2015 at 8:30 PM, blazkovicz notifications@github.com
wrote:

Thanks! Is update available already?

—
Reply to this email directly or view it on GitHub
#313 (comment)
.

[blazkovicz]

In version 2.1 several lines each of single dot are still invisible until hover.

[almossawi]

@blazkovicz Aah yes, multi-line ones ought to be updated to work in the same way. I'll take care of that.

[blazkovicz]

Next code gives error on data with color mapping, because there is no object ".mg-line1-color":

//if the dataset is of length 1, trigger the rollover for our solitary rollover rect
if (args.data.length == 1 && args.data[0].length == 1) {
    d3.select('.mg-rollover-rect .mg-line1-color')
        .on('mouseover')(args.data[0][0], 0);
}

Also, this code shows active-datapoint, unneeded in case with several lines on graphic.

[almossawi]

@blazkovicz I've assigned it to v2.2 so that I don't lose track of it. I'll get to this as soon a possible.

[almossawi]

The first issue, where a single line might have an identifier greater than one ought to be fixed.

The fix for multi-lines is incomplete, as it doesn't currently show multiple dots in the case where there are multiple lines that have a solitary observation. I might have to revisit this after v2.2.

[almossawi]

Tacking in #361