Linked minutes

[mikaelbr]

It seems as it isn't possible to have linked graphs on anything other than days, due to the hardcoded parsing for dates. This PR adds possibility to override this format, and thus being able to do linked hover on self defined granularity.

This PR also adds convenience npm scripts for building and testing:

$ npm run build

$ npm test

This makes it so that gulp doesn't have to be installed globally and thus makes it easier to have different gulp version across different projects.

[mikaelbr]

I see. It seems as the tests doesn't run with the old script though? It runs, but with 0 tests. I reverted the commit and squashed them

[dandehavilland]

It seems as the tests doesn't run with the old script though?

They're running for me locally and via travis with the current setup.

If installing gulp globally is not a viable solution, then we could reconfigure .travis.yml and package.json. Something like this:

# .travis.yml
...
script: npm run test-ci
...

# package.json
...
"scripts": {
  "build": "gulp build:js",
  "test": "gulp test",
  "test-ci": "./node_modules/testem/testem.js ci testem.json"
},
...

[mikaelbr]

I think that sounds like a good compromise. Installing gulp globally works as well, but it's considered bad practice IMO. I can update the commit.

[mikaelbr]

For some reason, when i run ./node_modules/testem/testem.js ci testem.json i get the following:

➜  metrics-graphics git:(linkedMinutes) ✗ npm run test-ci

> metrics-graphics@2.0.0 test-ci /projects/repos/metrics-graphics
> ./node_modules/testem/testem.js ci testem.json


1..0
# tests 0
# pass  0
# fail  0

# ok

[dandehavilland]

I don't know why that is. I ran ./node_modules/testem/testem.js ci testem.json on your branch and get:

1..80
# tests 80
# pass  80
# fail  0

# ok

[mikaelbr]

Strange. It seems to work when opening in the browser (running gulp test and opening the address.). Might be a headless browser problem. I'll try to investigate more later today.

[dandehavilland]

Ah yes, do you have PhantomJS installed?

[mikaelbr]

Ah. I didn't have it installed globally, so it didn't work as expected. Installed it globally now and it shows 80 tests.

[dandehavilland]

Cool, looks good. Will now just need a rebase against master.

[mikaelbr]

Maybe also the linked_format property should be in the defaults?

[almossawi]

Thanks, @mikaelbr 👍

@hamilton @dandehavilland Looks good to you?

[dandehavilland]

Yep, looks good to me.