Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "hint" attribute is not reliable in determining if the request will be responded to asynchronously #3

Closed
michaelfranzl opened this issue Dec 30, 2017 · 1 comment

Comments

@michaelfranzl
Copy link

if (signal.janus === "ack" && signal.hint) {

This is just a heads-up that the presence of the "hint" attribute depends on the server-side plugin implementation. If "hint" is not present in a synchronous response to a request, the asynchronous response will not resolve the corresponding Promise.

@mqp
Copy link
Contributor

mqp commented Jan 4, 2018

Ah, thanks for the heads-up. I didn't realize that when I wrote this. I will fix this up to be really correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants