Skip to content
This repository has been archived by the owner on Aug 20, 2018. It is now read-only.

Commit

Permalink
Bug 897967 - FirefoxRunner et al should subclass LocalRunner instead …
Browse files Browse the repository at this point in the history
…of Runner, r=jgriffin
  • Loading branch information
ahal-test committed Jul 25, 2013
1 parent cc82492 commit 5794e6b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
20 changes: 10 additions & 10 deletions mozrunner/mozrunner/local.py
Expand Up @@ -7,7 +7,7 @@
__all__ = ['CLI',
'cli',
'package_metadata',
'Runner',
'LocalRunner',
'local_runners',
'FirefoxRunner',
'MetroFirefoxRunner',
Expand Down Expand Up @@ -202,20 +202,20 @@ def _wrap_command(self, cmd):
return cmd


class FirefoxRunner(Runner):
"""Specialized Runner subclass for running Firefox."""
class FirefoxRunner(LocalRunner):
"""Specialized LocalRunner subclass for running Firefox."""

profile_class = FirefoxProfile

def __init__(self, profile, binary=None, **kwargs):

# take the binary from BROWSER_PATH environment variable
binary = binary or os.environ.get('BROWSER_PATH')
Runner.__init__(self, profile, binary, **kwargs)
LocalRunner.__init__(self, profile, binary, **kwargs)


class MetroFirefoxRunner(Runner):
"""Specialized Runner subclass for running Firefox.Metro"""
class MetroFirefoxRunner(LocalRunner):
"""Specialized LocalRunner subclass for running Firefox.Metro"""

profile_class = MetroFirefoxProfile

Expand All @@ -229,7 +229,7 @@ def __init__(self, profile, binary=None, **kwargs):

# take the binary from BROWSER_PATH environment variable
binary = binary or os.environ.get('BROWSER_PATH')
Runner.__init__(self, profile, binary, **kwargs)
LocalRunner.__init__(self, profile, binary, **kwargs)

if not os.path.exists(self.immersiveHelperPath):
raise OSError('Can not find Metro launcher: %s' % self.immersiveHelperPath)
Expand All @@ -239,14 +239,14 @@ def __init__(self, profile, binary=None, **kwargs):

@property
def command(self):
command = Runner.command.fget(self)
command = LocalRunner.command.fget(self)
command[:0] = [self.immersiveHelperPath, '-firefoxpath']

return command


class ThunderbirdRunner(Runner):
"""Specialized Runner subclass for running Thunderbird"""
class ThunderbirdRunner(LocalRunner):
"""Specialized LocalRunner subclass for running Thunderbird"""
profile_class = ThunderbirdProfile

local_runners = {'firefox': FirefoxRunner,
Expand Down
2 changes: 1 addition & 1 deletion mozrunner/setup.py
Expand Up @@ -6,7 +6,7 @@
from setuptools import setup

PACKAGE_NAME = "mozrunner"
PACKAGE_VERSION = '5.21'
PACKAGE_VERSION = '5.22'

desc = """Reliable start/stop/configuration of Mozilla Applications (Firefox, Thunderbird, etc.)"""

Expand Down

0 comments on commit 5794e6b

Please sign in to comment.