Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review use of Debug formatting and avoid in release-mode logging #140

Closed
kinetiknz opened this issue Jan 26, 2018 · 2 comments
Closed

Review use of Debug formatting and avoid in release-mode logging #140

kinetiknz opened this issue Jan 26, 2018 · 2 comments

Comments

@kinetiknz
Copy link
Collaborator

kinetiknz commented Jan 26, 2018

Related to issue #139, @bholley is working on reducing Debug trait use in release builds (for code size reasons). He proposed:

what we do in stylo is use debug! and trace! for stuff where we need/want :?, and then avoid :? in info/warn/log which are compiled in release builds

So we'll need to review existing log! use and replace with debug!/trace! as necessary and remove any use of :? inside log!.

@rillian
Copy link
Contributor

rillian commented Jan 30, 2018

This should be addressed for mp4parse now. Thanks for filing!

@rillian rillian closed this as completed Jan 30, 2018
@bholley
Copy link

bholley commented Jan 30, 2018

Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants