aframe-extras navmesh #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… replaced nav-mesh with new, much smaller one generated with blender navigation mesh tool; limiting teleport to navmesh; moved duck to be closer to edge of table;
|
Tried using having a detached part of the navmesh for the table and the shelf in the back of the room, but appears to be unsupported in the pathfinding library. |
brianpeiris
reviewed
Mar 30, 2018
| root.position.copy(clampedEnd); | ||
| root.position.x += this.velocity.x * dt / 1000; | ||
| root.position.y += this.velocity.y * dt / 1000; | ||
| root.z += this.velocity.z * dt / 1000; |
There was a problem hiding this comment.
This whole second applicaiton of velocity looks to be a copy/paste typo https://github.com/donmccurdy/aframe-extras/blob/master/src/controls/movement-controls.js#L124
src/room.html
Outdated
| @@ -168,7 +168,7 @@ | |||
| class="left-controller" | |||
| hand-controls2="left" | |||
| tracked-controls | |||
| teleport-controls="cameraRig: #player-rig; teleportOrigin: #player-camera; button: action_teleport_" | |||
| teleport-controls="cameraRig: #player-rig; teleportOrigin: #player-camera; button: action_teleport_; collisionEntities: #floor-nav" | |||
There was a problem hiding this comment.
nit: wrap the properties now that the component values are rather long.
# Conflicts: # src/room.html
# Conflicts: # src/components/character-controller.js # src/hub.html
netpro2k
reviewed
Apr 9, 2018
| //copied from aframe-extras movement-controls | ||
| if (this.velocity.lengthSq() > EPS) { | ||
| let start = root.position; | ||
| end.copy(this.velocity).multiplyScalar(dt / 1000).add(start); |
There was a problem hiding this comment.
Velocity is already applied above, root.position is already the target position we are trying to move to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added aframe-extras navmesh/pathfinding for our character-controller; replaced nav-mesh with new, much smaller one generated with blender navigation mesh tool; limiting teleport to navmesh; moved duck to be closer to edge of table;
Fixes #97