Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support protocol relative urls #235

Closed
leftieFriele opened this issue Jan 10, 2018 · 1 comment
Closed

support protocol relative urls #235

leftieFriele opened this issue Jan 10, 2018 · 1 comment

Comments

@leftieFriele
Copy link

Currently you have to implement a custom validation function in order to use protocol relative urls when using the url format in convict. The validator package supports the option allow_protocol_relative_urls when validating urls.

I know similar requests have been closed (#170, #93]. As far as I can tell adding this option to the validator.isUrl call in convict won't break anything. I'd be happy to create a PR for this if you all think this is a good idea.

@A-312
Copy link
Contributor

A-312 commented Dec 7, 2019

With my PR #327 , the url format will be a separated paclage see : https://github.com/A-312/node-convict/tree/nodep/packages/convict-validator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants