Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convict + react-scripts build + CI=true throws error #385

Closed
deema089786 opened this issue Apr 28, 2021 · 2 comments
Closed

Convict + react-scripts build + CI=true throws error #385

deema089786 opened this issue Apr 28, 2021 · 2 comments

Comments

@deema089786
Copy link

deema089786 commented Apr 28, 2021

When I try to build React app with react-scripts build (typescript) and env var CI=true I get this error

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Failed to compile.

./node_modules/yargs-parser/index.js
Critical dependency: the request of a dependency is an expression

When I remove all usage of Convict from my code or set CI=false - build goes as expected

convict: 6.0.1
"@types/convict": "^6.0.1",
react-scripts: 4.0.3

NodeJS: 14.15.1

Is there any way to deal with that? (except setting CI to false)

@dnlrsr
Copy link

dnlrsr commented Aug 12, 2021

+1 same here

@madarche
Copy link
Collaborator

madarche commented May 7, 2022

Duplicate of #400

@madarche madarche marked this as a duplicate of #400 May 7, 2022
@madarche madarche closed this as completed May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants