You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
If we want to use this module in goggles.webmaker.org we have to consider and implement the following:
One. getCurrentLang()
This function currently will take the language from the html attribute and return that and if it's not there then we return default en-US, but in x-ray goggles if they use the bookmarklet and saved a version different than English they should always have that language available depend on the URL in the script and not on the page they are visiting.
Two. URI and URL options in ready()
This is another issue where we have to implement in favour of x-ray goggles because we are using the script not only on the same domain, but also on a different location, so we need to have options we pass for URL -- https://goggles.webmaker.org/ or any host name and we will complete the rest inside our ready() in order to get the strings catalog. and the URI by default is /strings/ anyway, but if we have different path for that, so it is good to still keep this options.
Three. Cross Domain.
Not sure if this can be done directly here, but Access-Control-Allow-Origin is the issue that we faced in Popcorn Maker and Goggles at the moment, so if we can have this option set in our module then that is a good implementation.
I already have something done, but will need some advice and discussion if @humphd wants me to do a PR on some of these.
The text was updated successfully, but these errors were encountered:
Most of these issues in goggles are now addresses. for number 2 we have that in the latest version and the rest we have our own solution. This issue can now be closed.
If we want to use this module in goggles.webmaker.org we have to consider and implement the following:
One.
getCurrentLang()
html
attribute and return that and if it's not there then we return defaulten-US
, but in x-ray goggles if they use the bookmarklet and saved a version different than English they should always have that language available depend on theURL
in the script and not on the page they are visiting.Two. URI and URL options in
ready()
This is another issue where we have to implement in favour of x-ray goggles because we are using the script not only on the same domain, but also on a different location, so we need to have options we pass for
URL
--https://goggles.webmaker.org/
or any host name and we will complete the rest inside ourready()
in order to get thestrings catalog
. and the URI by default is/strings/
anyway, but if we have different path for that, so it is good to still keep this options.Three. Cross Domain.
Not sure if this can be done directly here, but
Access-Control-Allow-Origin
is the issue that we faced inPopcorn Maker
andGoggles
at the moment, so if we can have this option set in our module then that is a good implementation.I already have something done, but will need some advice and discussion if @humphd wants me to do a PR on some of these.
The text was updated successfully, but these errors were encountered: