Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use about: links in the show-heartbeat Learn More link #608

Closed
Osmose opened this issue Mar 13, 2017 · 3 comments
Closed

Cannot use about: links in the show-heartbeat Learn More link #608

Osmose opened this issue Mar 13, 2017 · 3 comments
Labels
Defect Something isn't as it should be P5 - Low Priority Patches welcome

Comments

@Osmose
Copy link
Contributor

Osmose commented Mar 13, 2017

Bugzilla: Bug 1346198

If you try to use an about: link as the URL for the "Learn More URL" field in show-heartbeat recipes, clicking the link fails with the following error message:

11:02:31.696 Error: Cannot open a about: link using the text-link binding. 1 text.xml:328
	open chrome://global/content/bindings/text.xml:328:15
	onxblclick chrome://global/content/bindings/text.xml:377:1
@Osmose Osmose added the Defect Something isn't as it should be label Mar 13, 2017
@mythmon
Copy link
Contributor

mythmon commented Oct 18, 2017

The fix here would probably have to be detecting about: links and adding our own click handlers to the link to open the correct page.

@Osmose
Copy link
Contributor Author

Osmose commented Oct 19, 2017

Adding a useoriginprincipal attribute to the element may also fix this; we had to do that for the link to about:studies in about:preferences.

@mythmon mythmon added P5 - Low Priority Patches welcome and removed good first issue labels Jan 30, 2018
@mythmon
Copy link
Contributor

mythmon commented Feb 5, 2018

Closing in favor of bug 1346198.

@mythmon mythmon closed this as completed Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Something isn't as it should be P5 - Low Priority Patches welcome
Projects
None yet
Development

No branches or pull requests

2 participants