Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

make it easier to configure auto-deploy for *upstream* repo #54

Closed
mykmelez opened this issue Oct 9, 2015 · 3 comments
Closed

make it easier to configure auto-deploy for *upstream* repo #54

mykmelez opened this issue Oct 9, 2015 · 3 comments
Assignees
Milestone

Comments

@mykmelez
Copy link
Contributor

mykmelez commented Oct 9, 2015

The configure command assumes that you want to auto-deploy merges to the master branch on the origin remote.

But for projects with multiple contributors, it's common for a user to fork the original repo and clone their fork, such that the origin remote points to their fork, and then create an upstream remote for the original repo, as described in GitHub's Fork A Repo documentation.

And it's actually more interesting to configure auto-deploy for the original, upstream repo, since that's the one in which people will more often merge changes via pull requests and want those merges to trigger auto-deploy.

But it's hard to do that right now. You have to either temporarily rename your remotes so the original remote is named origin (which actually sounds like a better name for it, although it is unconventional) or clone the original remote and configure that clone.

We should make it easier to configure auto-deploy for the upstream repo.

For example, we could prompt the user to choose the remote for which to configure auto-deploy, selecting the upstream remote by default if one is defined.

(A related problem is that you can't configure a repo to auto-deploy both the original repo and a fork, since the encrypted GitHub auth token in .travis.yml is repo-specific, and there can be only one auth token in the Travis build environment variables. But that's a different issue.)

@marco-c
Copy link
Contributor

marco-c commented Oct 14, 2015

There's an undocumented option in the gh-pages module that should make this easy: https://github.com/tschaub/gh-pages/blob/ab5a1bef7829bacd95e6034dd8f4354df665f2ba/lib/index.js#L64

@marco-c marco-c assigned marco-c and unassigned marco-c Oct 14, 2015
@marco-c
Copy link
Contributor

marco-c commented Nov 9, 2015

tschaub/gh-pages#24 would allow to do this.

@marco-c
Copy link
Contributor

marco-c commented Nov 16, 2015

Fixed by #165.

@marco-c marco-c closed this as completed Nov 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants