Don't show offline badges on badge index.

app.js

@@ -66,7 +66,7 @@ app.post('/admin/config', issuer.update);
 // Badge listing
 // -------------
 var indexMiddleware = [badge.findAll, behavior.findAll];
-app.get('/', badge.findAll, admin.all);
+app.get('/', badge.findNonOffline, admin.all);
 app.get('/admin', indexMiddleware, admin.badgeIndex);
 app.get('/admin/badges', indexMiddleware, admin.badgeIndex);
 

routes/badge.js

@@ -182,6 +182,7 @@ exports.findByClaimCode = function findByClaimCode(options) {
   }
 };
 
+// #TODO: refactor the following three fuctions into just one, probably
 exports.findByShortName = function (options) {
   var required = !!options.required;
 
@@ -210,10 +211,22 @@ exports.findByShortName = function (options) {
 
 exports.findAll = function findAll(req, res, next) {
   Badge.find({}, function (err, badges) {
-    // #TODO: don't show the error directly
-    if (err)
-      return res.send(500, err);
+    if (err) return next(err)
+    req.badges = badges;
+    return next();
+  });
+};
+
+exports.findNonOffline = function findNonOffline(req, res, next) {
+  var query = {
+    '$or': [
+      {claimCodes: {'$exists': false }} ,
+      {claimCodes: {'$size': 0 }}
+    ]
+  };
+  Badge.find(query, function (err, badges) {
+    if (err) return next(err);
     req.badges = badges;
-    next();
+    return next();
   });
 };