Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding comments/annotations (highlight) #14975

Closed
marco-c opened this issue May 31, 2022 · 13 comments
Closed

Support adding comments/annotations (highlight) #14975

marco-c opened this issue May 31, 2022 · 13 comments

Comments

@marco-c
Copy link
Contributor

marco-c commented May 31, 2022

We are experimenting with basic PDF editing features.
This issue tracks implementing support for highlighting text and adding comments/annotations.

@marco-c marco-c added this to To do in PDF.js editing via automation May 31, 2022
@Stamo-Gochev
Copy link

@marco-c Can you share more information about when the feature will be available? I see that no milestone has been defined and the issue is in the "to do" section, so I guess it is hard to tell, but I am working on a prototype project that will benefit from the functionality and as specifying a concrete release might not be possible, do you have plans to have this by the end of the year (2022)?

@marco-c
Copy link
Contributor Author

marco-c commented Jun 7, 2022

@Stamo-Gochev I hope we will be able to get to this soon, but unfortunately we can't make any promises regarding the timeline.

@qwer1304
Copy link

How to activate in Chrome? (I built it from sources).
I tried modifying annotationEditorEnabled in pdf.js\extensions\chromium to true and rebuilding, but PDFViewerApplicationOptions.get("annotationEditorEnabled") in console still gives false and there're no new options in viewer.

@xerz-one
Copy link

Is a preview available with build flags or in another repository? What is the intended UX workflow like?

@SuperPat45
Copy link

Please add ability to cross out text in addition to the highlight

@marco-c
Copy link
Contributor Author

marco-c commented Nov 18, 2022

Highlighting is not available yet, but you can draw or add text on PDFs with the latest version of Firefox.

@rubenkleiman
Copy link

Hi marco-c. Have you determined by now whether the pdf.js codebase is tractable for implementing annotations? If so, I might help on the coding end. API features I need: (1) highlight a text selection, (2) extract its PDF doc location and the text itself, and (3) edit or delete the highlighted text. The highlighted text has, of course, to be permanently embedded in the PDF. Thanks.

@marco-c
Copy link
Contributor Author

marco-c commented Mar 31, 2023

@rubenkleiman this issue is tracking implementing those features. It is feasible, but some work is required.

@avishaan
Copy link

avishaan commented Apr 5, 2023

@rubenkleiman we had a similar issue and solved it by forking pdf highlighter repo which builds on top of this. Check it out here https://github.com/credolabs/react-pdf-highlighter we would love to hear your ideas as well

@marco-c
Copy link
Contributor Author

marco-c commented Jul 28, 2023

There is now a meta bug on Bugzilla to track this work: https://bugzilla.mozilla.org/show_bug.cgi?id=1846098.

@marco-c
Copy link
Contributor Author

marco-c commented Nov 9, 2023

And https://bugzilla.mozilla.org/show_bug.cgi?id=1863905 about the commenting.

We will close this issue, you can follow along on Bugzilla.

@marco-c marco-c closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
PDF.js editing automation moved this from To do to Done Nov 9, 2023
@shivaprsd
Copy link

As basic annotation features are now available, the wiki should be updated.

/cc @timvandermeij

@timvandermeij
Copy link
Contributor

Thanks; I have updated the wiki now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

10 participants