-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce tests for CSS-only zooming #18105
Comments
I opened #18129 for the second point. Regarding the first point, I tried but I cannot figure out how to get Line 655 in 9ee7c07
I could check how big is exactly the window on my machine and which display density it reports, but it feels very brittle and specific to my setup. |
I'm not 100% sure, but looking at Lines 1014 to 1023 in 9ee7c07
maxCanvasPixels to a low value might already suffice to trigger CSS-only zooming? I think it could follow the same pattern as you already introduced in #18129. I agree that we shouldn't depend on the environment the test is run in; ideally we can simply force the viewer to use CSS-only zooming after e.g. a certain zoom percentage (the current viewer should already do that; try zooming to 900% and notice that the canvas doesn't change in terms of width/height attribute anymore in the web console).
|
In PR #18077 we found that we currently don't have any tests for the CSS-only zooming functionality in the viewer. We should ideally implement two (most likely integration) tests:
drawingDelay
also when CSS-only zooming is used (issue 18022) #18077 (see [api-minor] Respect thedrawingDelay
also when CSS-only zooming is used (issue 18022) #18077 (comment))./cc @nicolo-ribaudo
The text was updated successfully, but these errors were encountered: