Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICC profiles support for images #2856

Open
13xforever opened this issue Mar 1, 2013 · 7 comments

Comments

@13xforever
Copy link

commented Mar 1, 2013

Right now pdf.js ignores embedded color profiles of any kind.

Here's a test pdf that looks just fine with Windows Reader on Windows 8, but shows no support in PDF.js.

And yes, Firefox does work (same test, but as html: http://www.color.org/version4html.xalter)

@13xforever

This comment has been minimized.

Copy link
Author

commented Mar 1, 2013

Details:
firefox 21.0a2 (2013-02-28)
pdf.js version 0.7.256
screenshot: icc_pdf

@gigaherz

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2013

The HTML site shows version 2 support only in here (windows 7 x64, firefox aurora), is this something new to windows 8?

@gigaherz

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2013

SumatraPDF doesn't support those profiles either, so I wonder how important the support really is?

@13xforever

This comment has been minimized.

Copy link
Author

commented Mar 1, 2013

ICCv4 is disabled by default in Firefox, you have to flip gfx.color_management.enablev4 to True

@13xforever

This comment has been minimized.

Copy link
Author

commented Mar 1, 2013

I don't know how important it is, but I couldn't find any relevant bug, so I made a new one with links to test cases.

@gigaherz

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2013

Yeah it's okay, better to have a tracking bug. Worst case the devs would close as "won't fix", best case it gives some dev or contributor something to do ;P

@SamyCookie

This comment has been minimized.

Copy link

commented Sep 17, 2018

I don't know if it works, but if it can help someone to implement ICC profiles, I found this:
https://formats.kaitai.io/icc_4/javascript.html
It seems to be CC0 license, it may be a start to begin ICC profiles support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.