Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page becomes empty during zoom #3545

Closed
yurydelendik opened this issue Aug 5, 2013 · 7 comments · Fixed by #3546 or #3548
Closed

Page becomes empty during zoom #3545

yurydelendik opened this issue Aug 5, 2013 · 7 comments · Fixed by #3546 or #3548
Assignees

Comments

@yurydelendik
Copy link
Contributor

Very intermittent. Possible steps to replicate:

  1. Open http://mozilla.github.io/pdf.js/web/viewer.html
  2. Go to on page 3 and set zoom 75%
  3. Rapidly (within 1 sec) click zoom-out ('-') button two times

Notice one of the pages became empty.

@Snuffleupagus
Copy link
Collaborator

That most likely regressed in #3513. Unfortunately this isn't the only issue with that PR, which is why I have already asked @brendandahl to back it out (see comment: #3513 (comment)).

@yurydelendik
Copy link
Contributor Author

Yep, that's 65fd2c7. Let me back it out

@Snuffleupagus
Copy link
Collaborator

@yurydelendik I just ran git bisect, since I can still reproduce this intermittently after you did the back out.
I found that the issue actually seems to be a regression from PR #3461, since it works in the first commit before that one.

I still think that it was really good that you did the back out, since #3513 makes it even worse (w.r.t. presentation mode).

@brendandahl brendandahl reopened this Aug 5, 2013
@ghost ghost assigned brendandahl Aug 5, 2013
@timvandermeij
Copy link
Contributor

I can confirm the behaviour as described by @yurydelendik on Windows 7 x64 and Firefox 22 (HWA on) using the github.io web viewer.

@yurydelendik
Copy link
Contributor Author

I cannot replicate it after #3546

@brendandahl
Copy link
Contributor

I still can, will have a fix soon.

@timvandermeij
Copy link
Contributor

Does the github.io viewer have #3546? If so, then I can still replicate it.

Ninja edit: Brendan beat me to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants