Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure PDFView.close() really closes and releases all resource #5278

Closed
yurydelendik opened this issue Sep 8, 2014 · 3 comments
Closed

Ensure PDFView.close() really closes and releases all resource #5278

yurydelendik opened this issue Sep 8, 2014 · 3 comments
Labels
core

Comments

@yurydelendik
Copy link
Contributor

Currently when we are closing we are not checking if loading or page rendering in progress. Also pdfDocument.destroy is a async operation.

We should either wait for all operations (fonts are cleared, the loading and rendering operations) to complete or ensure all started operations are aborted and those will not have further effect on the viewer.
@yurydelendik yurydelendik added this to the 2014 Q4 milestone Sep 8, 2014
@yurydelendik
Copy link
Contributor Author

Re: https://bugzilla.mozilla.org/show_bug.cgi?id=1058695

@yurydelendik yurydelendik mentioned this issue Sep 8, 2014
Closed
@brendandahl brendandahl modified the milestones: 2014 Q4, 2015 Q1 Jan 8, 2015
@timvandermeij timvandermeij removed this from the 2015 Q1 milestone Apr 29, 2015
@timvandermeij
Copy link
Contributor

@yurydelendik Is this fixed by your recent PR?

@yurydelendik
Copy link
Contributor Author

Yes, indeed. Thanks.

Fixed by #6546

@yurydelendik yurydelendik mentioned this issue Oct 24, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brendandahl @yurydelendik @timvandermeij