Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

privacy policy and tos in-dialog doesn't work in all locales #1303

Closed
lloyd opened this issue Mar 13, 2012 · 6 comments
Closed

privacy policy and tos in-dialog doesn't work in all locales #1303

lloyd opened this issue Mar 13, 2012 · 6 comments

Comments

@lloyd
Copy link
Contributor

lloyd commented Mar 13, 2012

This is one of two issues, introduced in train-2012.03.01 that motivates derailing that train.

Because non-english languages weren't considered in the initial implementation, there are many cases where the dialog looks terrible or is simply unusable (esp in german and sweedish). This is a rollup issue that we'll use to track the underlying issue, and dependent issues will be closed down as dups and linked here.

@jbonacci
Copy link
Contributor

This is a new meta issue covering the following open/known issues: #1301, #1300, #1292, #1276, #1275, #1274, #1272, #1262, #1261, and #1240.

@shane-tomlinson
Copy link

close with checkin 8e5a3cce6cf5b86e8f7ae726a83ff1b00434ac62

@ghost
Copy link

ghost commented Mar 23, 2012

I've verified this issue on Windows 7 + Firefox 12.0 beta 2:
Issues 1300, 1292, 1275, 1274, 1272 aren't reproducing anymore.
Issues 1301, 1276 and 1240 are still reproducible.

I couldn't verify the iOS bugs due to lack of an iOS device.

@jbonacci
Copy link
Contributor

We will have Zak pick up some of this verification on Mac and iOS.

@jbonacci
Copy link
Contributor

Testing with Germanic and Asian languages looks good. Content, layout, and ability to select links and buttons is as expected. Waiting for final feedback from Zak.

@jbonacci
Copy link
Contributor

I think we are ok here for English and the locales currently on Stage. I tested as many as I could.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants