kpi interaction_data is uploaded even when /sign_in is not loaded in the dialog window

[jrgm]

This is mostly a question about whether this will present any unexpected data (perhaps not).

STR:

1. run a local dev instance and load http://127.0.0.1:10001. Click 'get an assertion'. Complete sign in.
2. Now load http://127.0.0.1/sign_in directly in another tab. Reload a couple of times.
3. Review the log output and ponder whether that will present any oddities.

The reason for this question is that certain browsers will open that url directly if you open a new window while the dialog has focus (e.g., IE and opera under default configuration).

[jedp]

Interesting. I don't know what to say about browsers opening that url directly, but as far as kpi goes, it looks like we should be aware that blobs that have empty event streams should not be tallied with the others.

We could also collect all blobs that have empty event streams and see what configurations produce them most. It wouldn't tell us anything about what went wrong, but it might give us a clue that certain browsers are producing a lot of false starts.

[lloyd]

@jedp suggests this might be a useful behavior. @nmalkin what do you think?

[nmalkin]

We could also collect all blobs that have empty event streams and see what configurations produce them most. It wouldn't tell us anything about what went wrong, but it might give us a clue that certain browsers are producing a lot of false starts.

Maybe it would be useful to log the errors that happened and include them as part of the KPI data blob.

as far as kpi goes, it looks like we should be aware that blobs that have empty event streams should not be tallied with the others.

This seems like the best solution. I'll do that.

[jrgm]

verified. kpi-dashboard will adjust to deal with these empty streams.