Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The repo last_synced_revisions value is not validated #3178

Closed
eemeli opened this issue Apr 17, 2024 · 0 comments · Fixed by #3179
Closed

The repo last_synced_revisions value is not validated #3178

eemeli opened this issue Apr 17, 2024 · 0 comments · Fixed by #3179
Labels
bug P3 Default, possibly shipping in the following two quarters sync

Comments

@eemeli
Copy link
Member

eemeli commented Apr 17, 2024

Pontoon keeps track of the last synced revision identifier, and uses this when determining what files have changed. However, if the repo has changed and that commit/changeset id is no longer valid, the current fallback behaviour is to swallow the error and to return an empty list. This means that any changed or removed files won't be detected and updated until they next change.

On error, we should probably default to returning all the files, which is what's done if the revision id is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P3 Default, possibly shipping in the following two quarters sync
Projects
Archived in project
2 participants