Skip to content
This repository has been archived by the owner on Jun 29, 2018. It is now read-only.

play() with time parameter not working on iOS 7 #398

Open
jywsn opened this issue May 9, 2014 · 6 comments
Open

play() with time parameter not working on iOS 7 #398

jywsn opened this issue May 9, 2014 · 6 comments
Assignees

Comments

@jywsn
Copy link

jywsn commented May 9, 2014

Calling play(N) with a time parameter N does not work on iOS 7. The clip will start playing at the beginning. The only way I could get it to start playing at a specified time was to use currentTime(n), bind a listener to the 'seeked' event, and then call play() in the associated callback.

@rwaldron rwaldron self-assigned this May 9, 2014
@rwaldron
Copy link
Contributor

rwaldron commented May 9, 2014

I have some spare cycles to look at this

@rwaldron
Copy link
Contributor

rwaldron commented May 9, 2014

@ScottDowne @cadecairos @jbuck my first thought is to actually use @jywsn's work around as the handling mechanism here: https://github.com/mozilla/popcorn-js/blob/master/popcorn.js#L613-L617 I'll keep playing around with this, but if anyone has better ideas, by all means :)

@ScottDowne
Copy link
Contributor

Waiting for seek feels pretty sane to me. I guess iOS 7 isn't handling this for us. If I recall correctly, spec says play and currentTime changes should queue and fire in the correct order, but I feel like it's probably pretty common for something like that to be simply not be implemented yet?

@rwaldron
Copy link
Contributor

Maybe we can feature detect for this and only do the special handling path if necessary?

@ScottDowne
Copy link
Contributor

I'm not too sure how we would feature detect this. Feels more like flaw detection than feature detection :P

Would we detect a generic feature we know is not on iOS then act accordingly? That feel like round about browser detection maybe? shrugs

I say don't bother with detection if the seek is not a problem in ff or chrome, and passes the tests.

@rwaldron
Copy link
Contributor

Yeah, I think you're right here. iOS has been edge-case for Popcorn.js anyway

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants