Skip to content
This repository has been archived by the owner on Jul 3, 2018. It is now read-only.

complete support for Electron webview load-commit event #70

Open
mykmelez opened this issue Jun 6, 2016 · 0 comments
Open

complete support for Electron webview load-commit event #70

mykmelez opened this issue Jun 6, 2016 · 0 comments

Comments

@mykmelez
Copy link
Contributor

mykmelez commented Jun 6, 2016

The webview-element branch #60 equates the webview event load-commit, as described in Electron webview docs, with the mozbrowser event mozbrowserlocationchange.

That might be correct, for the top-level frame, anyway, even though WebAPI/BrowserAPI/Common_Subset equates that event with the mozbrowserloadend.

But mozbrowserlocationchange doesn't appear to fire for sub-frame loads, whereas load-commit apparently does. And I haven't yet confirmed that the events are equivalent even for the top-frame load. Also, the implementation doesn't yet set the url and isMainFrame properties of the event object.

So we still need to implement complete support for the load-commit event.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant