Fix #243: Serve vendor favicons locally instead of remotely.

Tracking protection is blocking the eBay favicon from being loaded in private browsing mode, but serving it locally instead of fetching it from the internet avoids being blocked.
mozilla · Nov 28, 2018 · 4756acd · 4756acd
1 parent 4f0fe88
commit 4756acd
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 5 deletions.
diff --git a/src/img/favicons/amazon.ico b/src/img/favicons/amazon.ico
diff --git a/src/img/favicons/bestbuy.ico b/src/img/favicons/bestbuy.ico
diff --git a/src/img/favicons/ebay.ico b/src/img/favicons/ebay.ico
diff --git a/src/img/favicons/homedepot.ico b/src/img/favicons/homedepot.ico
diff --git a/src/img/favicons/walmart.ico b/src/img/favicons/walmart.ico
diff --git a/src/state/vendors.js b/src/state/vendors.js
@@ -23,27 +23,27 @@ const VENDORS = [
   {
     name: 'Amazon',
     hostnames: ['amazon.com', 'www.amazon.com', 'smile.amazon.com'],
-    faviconUrl: 'https://www.amazon.com/favicon.ico',
+    faviconUrl: browser.runtime.getURL('/img/favicons/amazon.ico'),
   },
   {
     name: 'Best Buy',
     hostnames: ['bestbuy.com', 'www.bestbuy.com'],
-    faviconUrl: 'https://www.bestbuy.com/favicon.ico',
+    faviconUrl: browser.runtime.getURL('/img/favicons/bestbuy.ico'),
   },
   {
     name: 'eBay',
     hostnames: ['ebay.com', 'www.ebay.com'],
-    faviconUrl: 'https://www.ebay.com/favicon.ico',
+    faviconUrl: browser.runtime.getURL('/img/favicons/ebay.ico'),
   },
   {
     name: 'The Home Depot',
     hostnames: ['homedepot.com', 'www.homedepot.com'],
-    faviconUrl: 'https://www.homedepot.com/favicon.ico',
+    faviconUrl: browser.runtime.getURL('/img/favicons/homedepot.ico'),
   },
   {
     name: 'Walmart',
     hostnames: ['walmart.com', 'www.walmart.com'],
-    faviconUrl: 'https://www.walmart.com/favicon.ico',
+    faviconUrl: browser.runtime.getURL('/img/favicons/walmart.ico'),
   },
   {
     name: 'mkelly Test',

diff --git a/webpack/common.config.js b/webpack/common.config.js
@@ -65,6 +65,7 @@ module.exports = {
       // Static files
       {from: '**/*.svg'},
       {from: '**/*.png'},
+      {from: '**/*.ico'},
       {from: '**/*.html'},
 
       // Experimental APIs, which are not bundled