Remove popup suggestions when Backspacing to nothing

[grssam]

With speakwords, when we are pressing backspace and then there is nothing left in the urlbar , the awesomebar popup still shows the suggestion based on the last left character.

type "firef" , popup shows suggestions for firefox , start pressing backspace till nothing is left , , awesome bar still shows suggestion for sites/urls/title containing "f"

[Mardak]

Not quite sure what event to look for. I tried from "input" where urlbar.value does indeed return "". But calling popupOpen is true and calling closePopup() does close it.. but it seems like something else is re-opening.

[grssam]

This listener is bringing back the popup

listen(window, gURLBar.parentNode, "keypress", function(event) {
switch (event.keyCode) {
case event.DOM_VK_BACK_SPACE:
case event.DOM_VK_DELETE:
// The value will be the last search if auto-selected; otherwise the
// value will be the manually selected autocomplete entry
if (gURLBar.value != lastSearch)
return;

    // Hack around to prevent deleting an entry
    let {mPopupOpen} = popup;
    popup.mPopupOpen = false;

    // Restore the original popup open value
    window.setTimeout(function() {
        popup.mPopupOpen = mPopupOpen;
      });       
    break;
}

});

But in this function there is no way to detect if the current keypress (delete or backspace) is going to make the urlbar value to null.

[grssam]

the guaranteed way I think is to check if cursor is at beginning while pressing delete for last char , and the cursor is at end while pressing backspace for last char

[Mardak]

How does that guarantee correctness when deleting a selection?

[grssam]

The fact that making a selection already remove the popup.
And to have nothing left after deleting a selection , the selection should enclose everything. That can be done only using either mouse or left right key presses , which removes the popup .

[Mardak]

How did you test this? It doesn't seem to close the popup suggestions for me.

[grssam]

sorry , there were some spelling mistakes , I fixed it at my patch-8 branch