Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define general layout stuff #10

Closed
craigcook opened this issue Mar 22, 2018 · 1 comment
Closed

Define general layout stuff #10

craigcook opened this issue Mar 22, 2018 · 1 comment
Projects

Comments

@craigcook
Copy link
Member

In olden days of yore, way back in 2016, we used a 12 column floated grid system with a span() mixin to set widths based on how many columns a box should span when it floated left. We have CSS Grid now, and honestly it always felt like the 12 column system was too printerly (when do you ever have something one column wide?). We'll still need to float things for older browsers but can use grid for modern ones.

So far we've been talking about getting away from a many-column system and thinking more in terms of plain old box sizes with a few standard units like "quarter", "third", "half" etc along with standard gutter widths. We could define these as variables/tokens and possibly some mixins but we haven't really dug into the particulars yet. So let's dig into it.

@craigcook
Copy link
Member Author

Parts of this are covered in #86

This issue when originally opened was deliberately vague because we didn't know everything it would entail at the time and knew it would work itself out. Well we have indeed figured out and defined a lot of the individual layout parts along the way, we just haven't documented them in this issue. That's on me.

What we've defined:

As broad and vague as this issue is I think we've achieved the spirit of "defining general layout stuff" so I'm happy to consider this completed.

Development automation moved this from In progress to Done May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development
  
Done
Development

No branches or pull requests

1 participant