Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand theme variables #931

Open
craigcook opened this issue Apr 25, 2024 · 1 comment
Open

Expand theme variables #931

craigcook opened this issue Apr 25, 2024 · 1 comment

Comments

@craigcook
Copy link
Member

craigcook commented Apr 25, 2024

To support multiple brands, Protocol treats lots of property values as variables, mainly colors, fonts, and font sizes. But there are more things we can make themeable with some more variables. Main ones off the top of my head:

border-width
border-style
border-color
border-radius
box-shadow

And likely more I'm not thinking of at the moment. We could potentially assign theme variables for spacing (padding and margins) as well, but I feel like spacing is one place where we can enforce some cross-brand consistency.

@craigcook
Copy link
Member Author

Thinking more about this, we should clarify that these aren't necessarily specific CSS properties, but aspects of a component's presentation that should be consistent across all instances of that component under a single theme.

For example, the rounded corners of buttons might be defined as a theme variable called button-border-radius and that value might differ between brands, but ALL buttons within a given brand theme would have the same border radius. That way Firefox buttons might have a 6px radius and Mozilla buttons might have a 0 border radius.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant