-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile Wikipedia site is broken #436
Comments
Can't reproduce with a quick check using desktop 60 beta. Also can't reproduce on Android (also 60 beta). Are you seeing this on iOS? Any chance you can gather more diagnostics? I don't have an iOS device myself... |
Yeah, this is in Firefox for iOS. I see no errors or anything in the web console. Maybe it’s only with certain pages? It definitely happens every time with the mobile version of the Mozilla entry: https://en.m.wikipedia.org/wiki/Mozilla |
Do you have a Mac by any chance? If so, you can reproduce in the iOS Simulator. |
This issue is specific to iOS 11. On iOS 10.3, the reader mode works fine on wikipedia. |
I have a mac, but I don't know how to install Firefox for iOS in the Simulator. I don't have disk space, time or brain cycles to build it from scratch, there's no store in the simulator, and it's not obvious how to download an iOS app from the store on my mac, and then install it into the simulator (or something). Even if I did know how to do all that, I don't know how to debug what's going on inside the iOS app. What version of readability is the iOS app using? Is it the same as what's on android/desktop? Does a previous version work? If you change the UA string, does that help? If you put the same markup we get from android/desktop devices on your own webpage and try to use it with that, does that work?
This makes it sound like either a UA sniffing issue in (mobile) wikipedia where they return different content that somehow then doesn't work, or an issue with the iOS app... |
Perhaps you can toggle the debug switch and get the debug output from readability, with a copy of the markup that's causing it to create wrong output, and that combination might help figure out what's going on here? Without being able to reproduce, it's very difficult for me to determine where the issue is... |
|
@gijsk is that sufficient to see what's going on? Let me know if there's anything else I can do on my end. Thanks! |
I think I've solved the problem. We were on commit 8525c6a. Updating to latest master seems to have fixed the result, although some things seem off like the "Edit" links next to the section headlines. |
OK, thanks for checking! The edit bits are covered in #424 . |
It seems as though all
m.wikipedia.org
mobile pages are unable to be parsed by readability.js. For example: https://en.m.wikipedia.org/wiki/MozillaThe text was updated successfully, but these errors were encountered: