Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded images are wrongly aligned with text #531

Closed
cognition9144 opened this issue Mar 12, 2019 · 4 comments
Closed

Embedded images are wrongly aligned with text #531

cognition9144 opened this issue Mar 12, 2019 · 4 comments

Comments

@cognition9144
Copy link

Embedded images are left-aligned with text, which allows the reader view horizontally scrollable. However, from the width of images it seems that images should fully occupy screen width.

Example: https://developer.mozilla.org/en-US/docs/Learn/CSS/Styling_boxes/Box_model_recap

@gijsk
Copy link
Contributor

gijsk commented Mar 12, 2019

Can you post a screenshot of what you're seeing, and check against a clean Firefox profile (perhaps there are additional steps necessary)? I don't see anything wrong with the link you provided when opened in reader mode - the images are as wide as the text. Perhaps you've customized the default text width or something else that might influence this bug?

@cognition9144
Copy link
Author

Sorry for the ambiguity. The problem happens in Firefox for Android, where the screen width is small.

@cognition9144
Copy link
Author

The images are out of boundary of the screen
photo_2019-03-13_17-14-11

And scrolling to the right is allowed, which seems that the image width is aligned with the screen width:
photo_2019-03-13_17-12-39

@gijsk
Copy link
Contributor

gijsk commented Mar 13, 2019

Ah, OK! Thanks for clarifying. This is an issue with reader mode on android, so I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1534942 and will close this one. The code in this github repository is only responsible for extracting the content from the original page; all the subsequent transformation and styling lives in Firefox for Desktop and Firefox for Android's own codebases, so will need fixing there.

@gijsk gijsk closed this as completed Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants