Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects.batch should complain if it doesn't get called with an array #43

Closed
gordonbrander opened this issue Mar 2, 2016 · 3 comments
Closed

Comments

@gordonbrander
Copy link

Currently calling Effects.batch(Effect, Effect, Effect) will fail silently. We should make this accidental call an exception or otherwise notify the developer.

@Gozala
Copy link
Contributor

Gozala commented Mar 31, 2016

One thing to keep in mind is that flow type checker will catch that error. That being said if user does not use flow it's not going to help much. I need to find a way to report such errors without introducing perf tax to users with a type checker. The problem isn't free if (!Array.isArray(fx)) { throw ... }.

I could probably have reflex.noflow.js builds that would have those extra checks.

@gordonbrander
Copy link
Author

@Gozala good point about the type checker. I'm not sure if its worth keeping this open.

@Gozala Gozala closed this as completed Jul 3, 2017
@Gozala
Copy link
Contributor

Gozala commented Jul 3, 2017

Closed as suggested in last comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants