Syscall one-off refactoring #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froydnj
force-pushed
the
syscall-one-off-refactoring
branch
from
a35cc8d
to
6ae9049
Compare
|
Updated branch because I failed to rebase on top of roc's recent changes. Also adding some handling for things I missed the first time around. I'm seeing consistent test failures in my VM for the cpuid tests; I assume that's related to the changes to check for the existence of the |
What do you mean? |
| // ${SYSCALL} must exist on the given architecture. | ||
|
|
||
| #define HAS_SYSCALL(_name) \ | ||
| inline bool has_ ## _name(SupportedArch arch) \ |
There was a problem hiding this comment.
For consistency, I think this should be has_##_name##_syscall
|
Generally this looks really good, by the way. |
Older systems like x86 had an mmap syscall that took a byte offset for the sixth argument. However, doing so meant that large files (> 4GB) couldn't be mmap'd. To address this, a replacement mmap2 syscall was created that took its offset in units of pages, rather than bytes. x86-64, however, has no problem with using byte offsets, and therefore has no mmap2 syscall. So we need to use the appropriate syscall for the architecture of the process we're tracing when making remote syscalls.
froydnj
force-pushed
the
syscall-one-off-refactoring
branch
3 times, most recently
from
05ba075
to
caaebd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series implements some of @rocallahan's earlier ideas on architecture-neutral replacements for
SYS_fooconstants. It handles just about everything, except for someSYS_socketcallconstants that need some better infrastructure insyscall_defs.h(we need to be able to talk about syscalls defined on x86-64 that aren't defined on x86--right now we only go the other direction) and some weird checks inemufs.ccthat I'm not immediately sure how to architecturialize (sp?).