New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ships a focus megazord and updates to 93.2.0 #56
Conversation
The changes in |
c66ddea
to
f327b0b
Compare
mozilla/application-services#4953 was landed and v93.2.0 was cut that has the artifact for focus This should be ready for review, I tested this branch against focus to make sure it builds ok I also ran the Edit: Also verified locally that firefox-ios builds ok, just out of caution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good to me. One thing i'm wondering is if this will potentially break some local published flows since there could now be potentially mismatches in the uniffi generated code.
Though most likely both components would never be used at the same time so that may not be an issue. I guess it depends on how XCode pulls in the entire Package.swift
All in all -- this looks good. Thanks on working on this!
Yeah I just double-checked 😬, in the package file in the apps it specifies which library it's using (firefox-ios has a section referencing |
The rust-components-swift part of mozilla/application-services#4821
Needs mozilla/application-services#4953 to land first, that PR also has the high-level reasoning for this.
What's changed in this PR
FocusAppServices
that depends on a separate binaryFocusRustComponents
that has only the components the focus needsswift-source/focus
swift-source/all
This will stay as a draft until mozilla/application-services#4953 lands and a release is cut.