Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for adding glean as an exposed library to our
rust-components-swift
. The change is very simple, it basically does what https://github.com/mozilla/glean-swift does and is meant to replace it for consumers, so we can ensure there is only one version of glean our consumers getThere is still one part missing from this change that I'll add, and that's the scripts. in
glean-swift
there is a useful script that updates the version, computes the checksum and creates a tag, we have a script ourselves that does similar things (minus the upgrading the version and computing the checksum, but it can very well do so)I am very open to feedback here, and if there are any other ways to do this (expose Glean) or other suggestions to make this easier, I'll happily take them!
cc: @badboy , this won't merge yet, I'll get to the scripts on my Tuesday (Monday is a Canadian Holiday!) but cc'ing you in case you have any thoughts or opinions on the general direction