Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose glean as a library #9

Closed
wants to merge 1 commit into from
Closed

Expose glean as a library #9

wants to merge 1 commit into from

Conversation

tarikeshaq
Copy link
Member

This is for adding glean as an exposed library to our rust-components-swift. The change is very simple, it basically does what https://github.com/mozilla/glean-swift does and is meant to replace it for consumers, so we can ensure there is only one version of glean our consumers get

There is still one part missing from this change that I'll add, and that's the scripts. in glean-swift there is a useful script that updates the version, computes the checksum and creates a tag, we have a script ourselves that does similar things (minus the upgrading the version and computing the checksum, but it can very well do so)

I am very open to feedback here, and if there are any other ways to do this (expose Glean) or other suggestions to make this easier, I'll happily take them!

cc: @badboy , this won't merge yet, I'll get to the scripts on my Tuesday (Monday is a Canadian Holiday!) but cc'ing you in case you have any thoughts or opinions on the general direction

@badboy
Copy link
Member

badboy commented Oct 11, 2021

What's the plan on updating this in the future?
Right now we automate this on a glean release to push an update to glean-swift. Should we then move that over to this repo?

@tarikeshaq
Copy link
Member Author

Hmm yeah, this raises a question related to https://github.com/mozilla/rust-components-swift/issues/10, we should decide what versioning looks like on this repository given that it will no longer hold just application services packages @skhamis and I were thinking the versions should reflect the AS versions, but that wouldn't make sense if we have glean in there too

@skhamis
Copy link
Contributor

skhamis commented Oct 14, 2021

Hmm this definitely raises some good questions I wonder if maybe we should have more discussions with stakeholders the best approach to this before exposing it as a target in this library. Since there are other consumers of glean I wonder if you just want glean we leave it as an option via glean-swift and if you want to use Nimbus you use A-S (which comes with glean). Definitely not ideal but happy to continue the discussion in an issue

@skhamis
Copy link
Contributor

skhamis commented Feb 2, 2022

I think we can safely close this now -- but i'll leave it to you!

@tarikeshaq tarikeshaq closed this Feb 2, 2022
@tarikeshaq tarikeshaq deleted the gleanify branch February 16, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants