Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print warning message by println instead of warn to avoid missing #1484

Closed
Xuanwo opened this issue Dec 17, 2022 · 1 comment · Fixed by #1554
Closed

Print warning message by println instead of warn to avoid missing #1484

Xuanwo opened this issue Dec 17, 2022 · 1 comment · Fixed by #1554
Labels

Comments

@Xuanwo
Copy link
Collaborator

Xuanwo commented Dec 17, 2022

sccache/src/config.rs

Lines 538 to 545 in ad97f69

if env::var("SCCACHE_GCS_CREDENTIALS_URL").is_ok() {
warn!("gcs deprecated_url has been deprecated");
}
if env::var("SCCACHE_GCS_OAUTH_URL").is_ok() {
warn!("SCCACHE_GCS_OAUTH_URL has been deprecated");
warn!("if you intend to use vm metadata for auth, please set correct service account intead");
}

We print warning message by warn here, which could be missed if RUST_LOG is not set or been set to ERROR. It's better to use println instead.

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Jan 11, 2023

@sylvestre Can you help mark this issue as help wanted and good first issue? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants