Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print sccache version while running --show-stats #1548

Closed
Xuanwo opened this issue Jan 10, 2023 · 7 comments
Closed

Print sccache version while running --show-stats #1548

Xuanwo opened this issue Jan 10, 2023 · 7 comments
Labels

Comments

@Xuanwo
Copy link
Collaborator

Xuanwo commented Jan 10, 2023

Print sccache version in stats will make it easier for debugging.

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Jan 11, 2023

@sylvestre Can you help mark this issue as help wanted and good first issue? Thanks.

@borjamunozf
Copy link
Contributor

borjamunozf commented Jan 17, 2023

Hi. I could try to do this if you want.

I have already done it, but not sure if this the idea.

Doubts about position/formatting:

  • Should it be first/latest print better? I guess versioning it's used to be shown as the first or latest thing on the output, but...
./target/debug/sccache --show-stats

Compile requests                      0
Compile requests executed             0
Cache hits                            0
Cache misses                          0
Cache timeouts                        0
Cache read errors                     0
Forced recaches                       0
Cache write errors                    0
Compilation failures                  0
Cache errors                          0
Non-cacheable compilations            0
Non-cacheable calls                   0
Non-compilation calls                 0
Unsupported compiler calls            0
Average cache write               0.000 s
Average compiler                  0.000 s
Average cache read hit            0.000 s
Failed distributed compilations       0
Cache location                  Local disk: "/home/borjamf/.cache/sccache"
Sccache version                0.4.0-pre.6

Thanks.

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Jan 17, 2023

I have already done it, but not sure if this the idea.

Yes! This is what I want.

  • Should it be first/latest print better? I guess versioning it's used to be shown as the first or latest thing on the output, but...

Showing along with cache location LGTM. In the future, maybe we can introduce sections like setup and statistics to make them more readable.

For the output content, we can remove the Sccache prefix, and only use Version.

@drahnr
Copy link
Collaborator

drahnr commented Jan 17, 2023

There should be a clear indicator that it's the client version.

@borjamunozf
Copy link
Contributor

borjamunozf commented Jan 17, 2023

There should be a clear indicator that it's the client version.

Do you mean something like this explicitly?

./target/debug/sccache --show-stats
Compile requests                      0
Compile requests executed             0
Cache hits                            0
Cache misses                          0
Cache timeouts                        0
Cache read errors                     0
Forced recaches                       0
Cache write errors                    0
Compilation failures                  0
Cache errors                          0
Non-cacheable compilations            0
Non-cacheable calls                   0
Non-compilation calls                 0
Unsupported compiler calls            0
Average cache write               0.000 s
Average compiler                  0.000 s
Average cache read hit            0.000 s
Failed distributed compilations       0
Cache location                  Local disk: "/home/borjamf/.cache/sccache"
Version (client)                0.4.0-pre.6

Or even some kind of concat like

....
Version              0.4-pre.6 (client)

Thanks.

@sylvestre
Copy link
Collaborator

Please avoid screenshot of text:

  • they are terrible for accessibility
  • they can't be searched
  • it is only text here anyway ;)

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Feb 11, 2023

PR has been merged, let's close this.

@drahnr drahnr closed this as completed Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants