Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sccache didn't take rustc version into hash calculation #1552

Closed
Xuanwo opened this issue Jan 11, 2023 · 0 comments · Fixed by #1553
Closed

Sccache didn't take rustc version into hash calculation #1552

Xuanwo opened this issue Jan 11, 2023 · 0 comments · Fixed by #1553

Comments

@Xuanwo
Copy link
Collaborator

Xuanwo commented Jan 11, 2023

    > For example, I ran into issues with `sccache` after upgrading the Rust toolchain. The cached binary object was missing logic present in the latest commit.

Oh, it must be a bug. Scache should generate different cache path after rust toolchain bumped.

let host = rustc_verbose_version
.lines()
.find(|l| l.starts_with("host: "))
.map(|l| &l[6..])
.context("rustc verbose version didn't have a line for `host:`")?
.to_string();

So far we only take host into consideration. I will work on fixing this.

Originally posted by @Xuanwo in #1528 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant