Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into removing the openssl dependency for gcs #223

Closed
luser opened this issue Feb 1, 2018 · 1 comment
Closed

Look into removing the openssl dependency for gcs #223

luser opened this issue Feb 1, 2018 · 1 comment

Comments

@luser
Copy link
Contributor

luser commented Feb 1, 2018

I realized that the gcs backend wasn't enabled in --features=all, so I fixed that, but it broke the AppVeyor build because it requires OpenSSL, which is a PITA to configure on Windows, so I added an all-windows feature that includes everything but gcs for now.

We did used to install OpenSSL for the AppVeyor build but I'm not eager to go back to that.

The only usage of OpenSSL is for parsing PEM files. @cramertj tried using the pem-parser crate during the initial landing of the gcs backend, but it's not usable enough unfortunately. It looks like the pem crate might be suitable. Some simple testing with random .pem key files on my system shows that it produces the same data as the openssl code that's currently in sccache.

@luser
Copy link
Contributor Author

luser commented Jul 16, 2019

This was fixed in #367

@luser luser closed this as completed Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant