Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc version detection #853

Closed
DemiMarie opened this issue Sep 17, 2020 · 5 comments
Closed

rustc version detection #853

DemiMarie opened this issue Sep 17, 2020 · 5 comments

Comments

@DemiMarie
Copy link

Currently, sccache is not aware of the version of rustc that it runs. Therefore, it is necessary to blow away the cache and start over after any Rust update.

@luser
Copy link
Contributor

luser commented Sep 17, 2020

This is a duplicate of #87, should have been fixed by #666. In the general case, sccache includes a hash of the compiler binary (or libs in the rustc case) in the cache key, but that didn't work well with rustup. It should be fixed nowadays.

@DemiMarie
Copy link
Author

Has the case of +nightly been fixed?

@froydnj
Copy link
Contributor

froydnj commented Sep 17, 2020

Has the case of +nightly been fixed?

I believe it has; if you have evidence to the contrary of this, please file a separate bug.

@drahnr
Copy link
Collaborator

drahnr commented Sep 28, 2020

Edit: The sample shown here did not reproduce due to overlaying error of rust-lang/rust#73993 with the latest stable version, other tests with master did not yield any success either using drahnr/railcar and spearow/juice as test subject.

rm -rf target; cargo +nightly-2020-06-30 b --no-default-features --features=native; rm -rf target;  cargo +nightly-2020-07-02 b --no-default-features --features=native

work just fine with latest master.

Could we please slate a new release so the fix is contained in a release?

@glandium
Copy link
Collaborator

I'm going to close this issue as the problem is fixed on master. The remaining part is for the fix to make it to a release, which I'm going to cut before the end of year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants