Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Turn off network.trr.fetch_off_main_thread #856

Closed
KershawChang opened this issue Mar 9, 2020 · 2 comments
Closed

Turn off network.trr.fetch_off_main_thread #856

KershawChang opened this issue Mar 9, 2020 · 2 comments
Assignees

Comments

@KershawChang
Copy link
Collaborator

See bug 1620824 [1].
TRR is not working properly with FPN extension when network.trr.fetch_off_main_thread is enabled.
We want to turn off network.trr.fetch_off_main_thread by FPN extension.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1620824

@bakulf
Copy link
Collaborator

bakulf commented Mar 9, 2020

If this is something that happens only in nightly, we can wait until the issue is fixed and uplift it to beta, if needed.

@KershawChang
Copy link
Collaborator Author

It's not easy to fix this in TRRServiceChannel, since the channel runs completely off main thread and doesn't send "http-on-*" notification. FPN extension has no way to add "Proxy-Authorization" header to the channel. In addition, we'd like to ship TRRServiceChannel in 75, so turning off "network.trr.fetch_off_main_thread" might be the best workaround for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants