Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Improve telemetry testing flag semantics #190

Open
gregglind opened this issue Jun 1, 2018 · 3 comments
Open

Improve telemetry testing flag semantics #190

gregglind opened this issue Jun 1, 2018 · 3 comments

Comments

@gregglind
Copy link
Contributor

it's annoying to 'remove testing flag'. Not sure how we should best solve this.

@motin
Copy link
Contributor

motin commented Jun 13, 2018

What is the purpose of the testing flag? Can we drop it? For automated tests, we can set the telemetry server endpoint to an invalid endpoint (done by default in geckodriver) so that automated test telemetry only lands in telemetry archive without being actually sent

@gregglind
Copy link
Contributor Author

This flag serves to mark garbage pings as garbage during the ping development process.

There is a lot to revise about ping development and analysis that impacts how we rip this out.

I agree it's currently not a great process.

@motin motin changed the title telemtry testing flag semantics. Improve telemetry testing flag semantics Nov 16, 2018
@motin
Copy link
Contributor

motin commented Mar 2, 2019

A suggestion for change in the utils for improving telemetry testing flag semantics is to change removeTestingFlag: false in the study setup to testing: true so that it is clearer when the telemetry pings are being marked for testing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants