Skip to content
This repository has been archived by the owner on Jul 3, 2019. It is now read-only.

github Copy URL doesn't work #878

Open
mcepl opened this issue Oct 26, 2013 · 20 comments
Open

github Copy URL doesn't work #878

mcepl opened this issue Oct 26, 2013 · 20 comments

Comments

@mcepl
Copy link

mcepl commented Oct 26, 2013

I guess, it's obvious: with Adobe flash, I have a small button to copy URL to my clipboard. Is it possible to get something like that with Shumway? How does Shumway deal with security settings?

@tschneidereit
Copy link
Contributor

Copy to Clipboard works for me on Github.

Currently, we just apply default security settings. Work on adding the
proper settings to the preferences panels, etc, is under way and will
obviously land before we get anywhere near to leaving the experimental
phase.

@mcepl
Copy link
Author

mcepl commented Oct 26, 2013

I cannot help myself but with Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 (which should have Shumway included, shouldn't it?) I don't see any button
screenshot from 2013-10-26 11 43 30

@tschneidereit
Copy link
Contributor

While Shumway is integrated into Nightly, it has to be enabled to work at
all. Even then, I'd recommend using the extension linked here. See the extension
documentation

for how to configure things.

@mcepl
Copy link
Author

mcepl commented Oct 26, 2013

Extension installed, shumway.ignoreCTP set to true, restarted Firefox, and still there is no button.
screenshot from 2013-10-26 12 19 37
There are tons of errors in the JavaScript console, but not sure which one of them are relevant (and which are just CSS, etc. cruft)

@tschneidereit
Copy link
Contributor

Mmh. Can you see the animation playing at the top of the areweflashyet.com page? If so, is there a small "shumway" button in the lower right corner of the animation? That would mean that Shumway works and the issue is specifically with the Github clipboard button. If you can't see the animation, something else is going on.

@mcepl
Copy link
Author

mcepl commented Oct 26, 2013

Yes, animations (cogwheels are rolling, flash is rotating, and the background colors are moving as well). No "shumway" button. Conflict with AdBlock Plus?
screenshot from 2013-10-26 15 21 48

@tschneidereit
Copy link
Contributor

Huh. That means that the Flash Player is used instead of Shumway. Can you
go over your configuration and the docs again to make sure that everything
is set up correctly? Sorry this is so complicated - we're working on it. :)

@yurydelendik
Copy link
Contributor

@mcepl looks like something interfering with Shumway. Please create a new profile and just switch "shumway.disabled" configuration flag.

@mcepl
Copy link
Author

mcepl commented Oct 26, 2013

@tschneidereit it is not possible, I don't have Flash plugin installed (checked against about:plugins)

@mcepl
Copy link
Author

mcepl commented Oct 26, 2013

Purely clean profile, just with shumway.disabled flipped. No button.
screenshot from 2013-10-26 20 46 26

@tschneidereit
Copy link
Contributor

Oh, I see. I think I know what's going on, then. Until bug 867626 is fixed, some sites -
apparently including Github - will fail to detect Flash playback capability
if the Flash plugin isn't installed. Ironically, that means that, for those
sites, you need to have the plugin installed in order to not need the
plugin to play back Flash content. ;)

@yurydelendik
Copy link
Contributor

bug 867626 sounds like a reasonable explanation.

The "Shumway" button is visible when Shumway is an overlay (for click-to-play) and it's possible to fallback to the native plugin. If native plugin is not available, object element still can load shumway by content type hint.

On the main page http://mozilla.github.io/shumway/ we fallback to iframe (as fallback content for object tag). To make sure the main.swf is not iframe, check "This Frame"->"View Frame Info" in the movie context menu (for iframe it is http://mozilla.github.io/shumway/iframe/viewer.html?swf=../main.swf).

@mcepl
Copy link
Author

mcepl commented Oct 27, 2013

What do I do wrong in http://mcepl.fedorapeople.org/tmp/shumway-screencast.webm that I am getting resource://shumway/web/viewer.html?

@yurydelendik
Copy link
Contributor

@mcepl, you are good and shumway is working as expected, just github checks navigator.plugins and not finding Adobe Flash plugin entry there. See https://bugzilla.mozilla.org/show_bug.cgi?id=867626 for details.

@cpeterso
Copy link
Contributor

Is GitHub Copy URL really an M2 blocker? :)

@mcepl
Copy link
Author

mcepl commented Feb 27, 2014

Is GitHub Copy URL really an M2 blocker? :)

Well, I don’t think this is only about Copy URL ... the previous comment seems to suggest that it is more about navigator.plugins, isn’t it?

@tschneidereit
Copy link
Contributor

The M2 blocker classification isn't about whether something is important or
not, but about whether it makes sense to make our next milestone depend on
it. In this case, I'm inclined to say "no", because it doesn't integrate
with the rest of our theme for that milestone (which, very roughly, is
moving things off the mainthread and getting proper compositing working).

Additionally, this fully depends on changes in the Gecko platform that
aren't under our team's control.

@cpeterso cpeterso modified the milestones: Release Landing, M2 Off Main Thread Shumway Mar 7, 2014
@cpeterso
Copy link
Contributor

cpeterso commented Mar 7, 2014

GitHub's Copy URL works for me with Shumway 0.8.209.

@cpeterso cpeterso closed this as completed Mar 7, 2014
@mcepl
Copy link
Author

mcepl commented Mar 7, 2014

GitHub's Copy URL works for me with Shumway 0.8.209.

Is it in Nightly? I don’t see anything with Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 (as of 2014-03-07).

@cpeterso
Copy link
Contributor

cpeterso commented Mar 7, 2014

oops. This is still half-broken. I just retested new profiles with:

  • Nightly 30.0a1 (2014-03-07) with Shumway version bundled
  • Nightly 30.0a1 (2014-03-07) with Shumway 0.8.267 extension from GitHub
  • Firefox 27 with Shumway 0.8.267 extension from GitHub

The first time I click the "copy to clipboard" button, the URL is copied and the following messages are logged to the web console:

"__flash__eval: try { __flash__toXML(ZeroClipboard.dispatch("mouseDown",({flashVersion:"SHUMWAY 10,0,0,0",altKey:false,ctrlKey:false,shiftKey:false}))) ; } catch (e) { "<undefined/>"; }" <unknown>
"__flash__eval: try { __flash__toXML(ZeroClipboard.dispatch("dataRequested",({flashVersion:"SHUMWAY 10,0,0,0",altKey:false,ctrlKey:false,shiftKey:false}))) ; } catch (e) { "<undefined/>"; }" <unknown>
"__flash__callIn: setText" frameworks-855d68c505f4b08a77e4d991f11cf5d8f43250e2.js:11
"__flash__eval: try { __flash__toXML(ZeroClipboard.dispatch("complete",({flashVersion:"SHUMWAY 10,0,0,0",altKey:false,ctrlKey:false,shiftKey:false,text:"https://github.com/mozilla/badgekit-api.git"}))) ; } catch (e) { "<undefined/>"; }" <unknown>
"__flash__eval: try { __flash__toXML(ZeroClipboard.dispatch("mouseUp",({flashVersion:"SHUMWAY 10,0,0,0",altKey:false,ctrlKey:false,shiftKey:false}))) ; } catch (e) { "<undefined/>"; }" <unknown>

The second time I click the button, the clipboard is set to an empty string and the following messages are logged to the browser console:

"__flash__eval: try { __flash__toXML(ZeroClipboard.dispatch("mouseDown",({flashVersion:"SHUMWAY 10,0,0,0",altKey:false,ctrlKey:false,shiftKey:false}))) ; } catch (e) { "<undefined/>"; }" <unknown>
"__flash__eval: try { __flash__toXML(ZeroClipboard.dispatch("dataRequested",({flashVersion:"SHUMWAY 10,0,0,0",altKey:false,ctrlKey:false,shiftKey:false}))) ; } catch (e) { "<undefined/>"; }" <unknown>
"__flash__callIn: setText" frameworks-855d68c505f4b08a77e4d991f11cf5d8f43250e2.js:11
"__flash__eval: try { __flash__toXML(ZeroClipboard.dispatch("mouseUp",({flashVersion:"SHUMWAY 10,0,0,0",altKey:false,ctrlKey:false,shiftKey:false}))) ; } catch (e) { "<undefined/>"; }" <unknown>

Note that the second test is missing the "complete" message! If I continue clicking the button, the clipboard will alternate between the URL and empty string. This might be a race condition because the problem seems more likely to happen if I click the button by quickly tapping my MacBook Pro's touchpad than if I actually slowly press/click the touchpad. Sometimes the "complete" logged but not "dataRequested".

@cpeterso cpeterso reopened this Mar 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants