Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Do not obscure the files object in verbose output #186

Closed
kumar303 opened this issue Sep 13, 2016 · 2 comments
Closed

Do not obscure the files object in verbose output #186

kumar303 opened this issue Sep 13, 2016 · 2 comments

Comments

@kumar303
Copy link
Contributor

If you do something like web-ext sign --verbose (which calls signAddon({verbose: true})) then you get a log of API responses. However, the files array is not shown. This is crucial part of the output for debugging purposes so we should show it. Example:

response:
   { guid: 'blok@mozilla.org',
     active: false,
     automated_signing: true,
     url: 'https://addons.mozilla.org/api/v3/addons/blok@mozilla.org/versions/1.0rc6/uploads/94b362a2b65f482aa6bf54397dbbb976/',
     files: [ [Object] ],
     passed_review: false,
     pk: '94b362a2b65f482aa6bf54397dbbb976',
     processed: true,
     reviewed: false,
     valid: true,
     validation_results:
      { errors: 0,
        success: true,
        warnings: 0,
        messages: [Object],
        passed_auto_validation: true,
        ending_tier: 5,
        compatibility_summary: [Object],
        detected_type: 'extension',
        signing_summary: [Object],
        notices: 1,
        signing_ignored_summary: [Object],
        metadata: [Object] },
     validation_url: 'https://addons.mozilla.org/en-US/developers/upload/94b362a2b65f482aa6bf54397dbbb976',
     version: '1.0rc6' } }
@kumar303 kumar303 changed the title Do not obscure the files object in verbose signing output Do not obscure the files object in verbose output Sep 13, 2016
@kumar303
Copy link
Contributor Author

We should just log all nested objects at an infinite depth (or a very large depth).

@stale
Copy link

stale bot commented Jul 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

@stale stale bot added the state: stale label Jul 6, 2020
@stale stale bot closed this as completed Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant