Fixes bug 731822 - Decode double encoded slashes in signature summary…

… service.
mozilla-services · Mar 14, 2012 · 6df8779 · 6df8779
1 parent dfd3d29
commit 6df8779
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/socorro/external/postgresql/signature_summary.py b/socorro/external/postgresql/signature_summary.py
@@ -51,6 +51,11 @@ def get(self, **kwargs):
             ]
 
         params = external_common.parse_arguments(filters, kwargs)
+
+        # Decode double-encoded slashes in signature
+        if params["signature"] is not None:
+            params["signature"] = params["signature"].replace("%2F", "/")
+
         if params['versions'] and params['report_type'] is not 'products':
             glue = ','
             version_search = ' AND reports_clean.product_version_id IN (%s)'

diff --git a/webapp-php/application/models/signature_summary.php b/webapp-php/application/models/signature_summary.php
@@ -19,7 +19,7 @@ public function getSummary($report_type, $signature, $start, $end, $versions = a
         $service = new Web_Service($config);
         $host = Kohana::config('webserviceclient.socorro_hostname');
         $report_type = rawurlencode($report_type);
-        $signature = rawurlencode($signature);
+        $signature = rawurlencode(str_replace('/', '%2F', $signature));\
         $start_date = rawurlencode($start);
         $end_date = rawurlencode($end);
         $url = "{$host}/signaturesummary/report_type/{$report_type}/signature/{$signature}/start_date/{$start_date}/end_date/{$end_date}";
@@ -30,7 +30,7 @@ public function getSummary($report_type, $signature, $start, $end, $versions = a
 
                 if(isset($versions['versions']) && !empty($versions['versions'])) {
                                 $url .= "/versions/{$versions['versions']}";
-                                        }  
+                                        }
 
         $resp = $service->get($url);