fixes Bug 893585 - remove thirty frame signature restriction #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if make_modules_lower_case: | ||
| try: | ||
| module_name = module_name.lower() | ||
| except AttributeError: |
There was a problem hiding this comment.
I'm generally not a fan of ignoring exceptions. Why are we not doing anything here to catch/log this exception?
There was a problem hiding this comment.
The only change to that handler in this PR is the indentation. It is out of the scope of this PR to worry about the philosophy of exception handling on code that has been in use for literally years.
There was a problem hiding this comment.
and the exception is ignored because it just means that the value of module_name is None, a perfectly legal situation. there's no need to log or otherwise deal with the exception.
|
Answer works for me. r+ |
brandonsavage
added a commit
that referenced
this pull request
Jul 18, 2013
fixes Bug 893585 - remove thirty frame signature restriction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Way back in 2009, we restricted signatures to come from the top thirty frames of the crashing thread. Apparently, this is less useful in these modern days. This PR removes the 30 frame restriction.