fixes bug 884944 - Colors in /daily once again don't match #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -537,6 +550,11 @@ def daily(request, default_context=None): | |||
| context['data_table'] = data_table | |||
| context['graph_data'] = json.dumps(cadu) | |||
| context['report'] = 'daily' | |||
| print context['os_names'] | |||
|
This still doesn't actually fix the issue which was reported, namely the fact that the table colors don't match the graph colors. See attached screenshot, where the purple line actually represents WaterWolf 5.0a1's data from the table. In fact, the labels on the graph don't match the data they display (even though they DO correlate with the specific color in the table). r- |
|
As discussed in person, the ordering of the versions has now been fixed in peterbe@187e18b |
| @@ -246,7 +246,6 @@ | |||
| <div class="body"> | |||
| <div id="adu-chart"></div> | |||
| <p class="adu-chart-help">This graph uses an approximate <a href="https://wiki.mozilla.org/Socorro/SocorroUI/Branches_Admin#Throttle">throttle value</a> for each version, which may not be completely accurate for the entire time period.</p> | |||
| <div id="adu-chart-legend"></div> | |||
There was a problem hiding this comment.
Why did we remove this?
|
r+ when Leeroy is happy. FWIW I ran the tests locally and they pass. |
|
Merged 9a11802 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brandonsavage r?
I recommend you pull down my fork and play around with it.