fixes bug 916886 - retry on ConnectionError on middleware #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,8 +66,21 @@ class SocorroCommon(object): | |||
| # default cache expiration time if applicable | |||
| cache_seconds = 60 * 60 | |||
|
|
|||
| # how many seconds to sleep when getting a ConnectionError | |||
There was a problem hiding this comment.
why not put these in the config (just hardcode in base.py so people can override)?
|
r+ (assuming test passes) - code and test lgtm, and seems to run fine under normal operation. I wish it were not necessary though, odd that we get so many connection errors. |
|
We don't really do logging in the django code but perhaps we should have a statsd metric specifically for counting how many and much this happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rhelmer r?
cc @AdrianGaudebert
This means that when the webhead is unable to connect to the middleware it gets 10 attempts spread across 30 seconds to retry.