fixes bug 974726 - implement correlations using postgres #1908
Conversation
|
The existing tables were actually pretty close to what we need - had to make various adjustments. The SPs not so much. |
|
@selenamarie so I think this is ready to go in - the only thing is that the correlations crontabber job is still part of the set of matviews, so we need to do some extra work if you want that split out. I would like to see how fast it is in practice and see if we can optimize it rather than splitting it out though, what do you think? |
|
@rhelmer that's fair! I'm happy to let it run and see. Seems fast enough for sure currently. |
| @@ -258,47 +258,46 @@ class Tcbs(DeclarativeBase): | |||
| ) | |||
|
|
|||
|
|
|||
| class CorrelationAddon(DeclarativeBase): | |||
| class CorrelationAddons(DeclarativeBase): | |||
There was a problem hiding this comment.
So -- the convention I've always heard was using singular for the Object and plural for the table...
|
We also need a migration. |
|
@selenamarie - got requested changes done, and rebased against latest alembic and fakedata changes. Can we get this in as-is and tackle running it with a separate crontabber as a separate bug? As-is this will establish the update/backfill functions but they will not be run. |
|
Agree re: separate crontabber :) |
|
r+ |
…stgres fixes bug 974726 - implement correlations using postgres
No description provided.