add drop_old_partitions crontabber job & test; bug 1014128 #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| http://socorro.readthedocs.org/en/latest/databaseadminfunctions.html#drop | ||
| -old-partitions | ||
| See https://bugzilla.mozilla.org/show_bug.cgi?id=1014128 | ||
| """ |
There was a problem hiding this comment.
Thank you! Thank you for using this space to write a really good description with good links.
|
Sorry, I hijacked this PR review. A couple of nits but r- on the lack of tests of the actual PG "content" and risk of a lingering table. |
| # Determine date of Monday preceeding year-old-date. | ||
| # This is an add operation but of a negative value, so subtraction. | ||
| year_old_monday = one_year_ago + timedelta(days=delta_previous_monday) | ||
|
|
There was a problem hiding this comment.
Just a nit because this code works fine but I find it a little confusing (comments help here 👍 ) - dateutil.relativedelta has weekday instances, this might read a little better if you use MO to get the previous Monday.
unlinks the nightly builds report from the UI and removes the URL route so the page cannot be accessed directly. Reverting this will restore functionality. A follow up bug will be filed to remove the code generating this report.
|
@phrawzty needs rebase |
Removes the unlinked view for the nightly builds report. This leaves the model and api call intact; it is less clear who is using that and how.
1021520 unlink the builds report
At startup, these would be S98socorro-*.pid and log, and if you did 'service socorro-foo start' it would just be socorro-*.pid. This unifies it by stripping S?? prefixes.
…fig-in-deploy deploy: Point crontabber partitioning at ini.
initscripts: Fix log & pidfile name.
…t-install-src-doc bug 1027664 - split dev/prod install docs
…alize-correlations-module Bug1025987 normalize correlations module
make it explicit where manage.py is, and pass --noinput to syncdb
|
Oh god this is some nonsense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rhelmer
r?(Please be gentle.)